search

hapijs / good

hapi process monitoring
Other
525 stars 160 forks source link

Updated README.md #596

Closed dan-h-ch closed 5 years ago

dan-h-ch commented 5 years ago

Created a PR based on comments in this thread.

https://github.com/hapijs/good/issues/527

Hopefully saves someone few hours of searching and getting lucky.

dan-h-ch commented 5 years ago

Yeah, I'm not sure why a change to readme would cause checks to fail. It is possible checks are failing on master?

EDIT - I just checked other open PR's and looks like checks are failing for all of them.

Marsup commented 5 years ago

This doesn't look like a necessary change. It's valid javascript and having await in the example already assumes a recent version of node.

arb commented 5 years ago

As stated in the linked issue, this is valid and common ES2015 code.

dan-h-ch commented 5 years ago

Yes, it's totally valid code but I think a bit confusing to follow as an example.

Marsup commented 5 years ago

How so? You're unlikely to be reading this readme if you're still learning the language, I'd say it's fair to use features people are supposed to know anyway.

dan-h-ch commented 5 years ago

I'm not saying it's not fair, but I feel like it could be a bit more friendly. While ES2015 should be widely adopted, I think feel like there may be some developers that are not using all the syntactical sugar that it came with.

Marsup commented 5 years ago

Then they might learn something.