Record null responseTime when request is aborted

hapijs / good

hapi process monitoring

Other

525 stars 161 forks source link

Record null responseTime when request is aborted #618

Closed rankida closed 5 years ago

rankida commented 5 years ago

As the hapi API docs say here the info.responded can be 0 in some cases such as aborted requests.

Just now good will output responseTime of -Date.now().

This PR changes this to set responseTime to null to better reflect the 0 responded value.

rahaack commented 5 years ago

Should request.info.responded just be replaced with request.info.completed?

From the hapi 18 release notes:

rankida commented 5 years ago

Seems like a sensible suggestion

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.