search

hapijs / hapi-pino

🌲 Hapi plugin for the Pino logger
MIT License
148 stars 61 forks source link

Make wrapSerializers optional #168

Closed lukeg90 closed 2 years ago

lukeg90 commented 2 years ago

I think this should have been added as an optional property.

lukeg90 commented 2 years ago

Could you add a test for this? We use tsd to test our types

Add a test for what exactly? The property is already included in this test file:

https://github.com/pinojs/hapi-pino/blob/master/index.test-d.ts

mcollina commented 2 years ago

If a change is needed, then the existing tests are not covering it. Therefore we need a new test.

jonathansamines commented 2 years ago

These changes were implemented by #173. Should we close this PR?