search

hapijs / hapi-pino

🌲 Hapi plugin for the Pino logger
MIT License
148 stars 61 forks source link

Are there plans to support Hapi v21? #179

Open rossanthony opened 1 year ago

rossanthony commented 1 year ago

As well as updating the dev dependency to hapi v21 here it seems like the types dependency of "@types/hapi__hapi": "^20.0.10" should be removed, since the types are now included with the core library of Hapi since v21: https://github.com/hapijs/hapi/tree/master/lib/types

Would I be able to help by opening a PR to take care of this? Looks like there's a need to cut a new major version of hapi-pino (v12) which will work with Hapi v21 typescript projects.

mcollina commented 1 year ago

Sure thing, send a PR over!

rossanthony commented 1 year ago

thanks @mcollina here's the PR: https://github.com/pinojs/hapi-pino/pull/180. The tests for the types had to be tweaked a bit, following the changes in Hapi v21 related to the Server type and the new server function that starts and returns a server.

Also thought it might be helpful to include a table of the hapi and pino versions supported by each version of this library, since we had some confusion around this earlier today when updating one of our projects to Hapi v21. We saw there was a v11 of hapi-pino but the readme only mentions as far as v9 in terms of support for hapi v20. So we tried it out hoping that maybe the latest hapi-pino would work with hapi v21.