hapijs / hapi

The Simple, Secure Framework Developers Trust
https://hapi.dev
Other
14.56k stars 1.33k forks source link

Shrinkwrap error for boom due to pez #3371

Closed cmathe closed 7 years ago

cmathe commented 7 years ago

Here is the result when I try to run npm shrinkwrap in my application :

npm WARN unmet dependency C:\dev\workspaces\platform\plateforme-backend\node_modules\hapi\node_modules\subtext\node_modules\pez requires boom@'3.x.x' but will load npm WARN unmet dependency C:\dev\workspaces\platform\plateforme-backend\node_modules\hapi\node_modules\boom, npm WARN unmet dependency which is version 4.0.0

I got the same problem if I remove npm-shrinkwrap file from hapi in my node_modules folder and try to run npm shrinkwrap inside hapi module.

Actually hapi@15.2.0 wants boom 4.x.x in its package.json, and force pez to 2.1.2 in its npm-shrinkwrap.json but pez@2.1.2 wants boom 3.x.x. Upgrading pez to 2.1.3 in shrinkwrap file should be enough to fix that problem.

peteut commented 7 years ago

For me it works fine using npm@3. This is probably a duplication of #3359.

package.json:

  "name": "partsdb",
  "version": "0.0.1",
  "description": "EEE Parts API",
  "private": true,
  "main": "index.js",
  "files": [
    "dist/"
  ],
  "config": {},
  "scripts": {
    "repl": "babel-node --presets es2015",
    "lint": "eslint ./src ./test",
    "build": "webpack",
    "test": "lab",
    "prepublish": "npm run build",
    "pretest": "npm run lint",
    "shrinkpack": "npm install --no-optional && npm shrinkwrap --dev && shrinkpack .",
    "watch:test": "watch 'npm test' ./src ./test --wait=30"
  },
  "repository": {
    "type": "git",
    "url": "https://spacegit.unibe.ch/electronics/parts-db.git"
  },
  "keywords": [
    "EEE",
    "parts"
  ],
  "author": "Alain Péteut",
  "email": "alain.peteut@space.unibe.ch",
  "license": "UNLICENSED",
  "bugs": {
    "url": "https://spacegit.unibe.ch/electonics/parts-db/issues"
  },
  "babel": {
    "presets": [
      "es2015"
    ]
  },
  "homepage": "https://spacegit.unibe.ch/electronics/parts-db#readme",
  "dependencies": {
    "awilix": "^1.0.0",
    "babyparse": "^0.4.6",
    "bluebird": "^3.4.6",
    "boom": "^4.2.0",
    "camelcase": "^3.0.0",
    "hapi": "^15.2.0",
    "iconv-lite": "^0.4.13",
    "joi": "^9.2.0",
    "js-data": "^2.9.0",
    "js-data-sql": "git://github.com/peteut/js-data-sql#c94819f",
    "knex": "0.12.3",
    "ldapjs": "^1.0.0",
    "nconf": "^0.8.4",
    "ramda": "^0.22.1",
    "ramda-fantasy": "^0.7.0",
    "snake-case": "^2.1.0",
    "sqlite3": "^3.1.4"
  },
  "devDependencies": {
    "babel-core": "^6.14.0",
    "babel-loader": "^6.2.5",
    "babel-preset-es2015": "^6.14.0",
    "code": "^4.0.0",
    "eslint": "^3.8.1",
    "eslint-config-airbnb": "^12.0.0",
    "eslint-plugin-import": "^1.16.0",
    "eslint-plugin-jsx-a11y": "^2.2.2",
    "eslint-plugin-react": "^6.3.0",
    "glob": "^7.1.0",
    "json-loader": "^0.5.4",
    "lab": "^11.1.0",
    "qs": "^6.3.0",
    "shrinkpack": "^0.17.1",
    "watch": "^1.0.1",
    "webpack": "^1.13.2"
  },
  "optionalDependencies": {
    "babel-cli": "^6.18.0"
  }
}
cmathe commented 7 years ago

Yes I agree, duplicating #3359