Set deepEqual() prototype option to true by default, not just when no options are passed

hapijs / hoek

Node utilities shared among the extended hapi universe

Other

480 stars 171 forks source link

Set deepEqual() prototype option to true by default, not just when no options are passed #299

Closed hueniverse closed 5 years ago

hueniverse commented 5 years ago

This is clearly a bug in the way default options are set, but it does create a breaking change.

Not sure if I should revert it or not.

kanongil commented 5 years ago

Hmm, I'm not sure. Anyway, it doesn't seem to effect the usages in the hapi modules.

Hoek.contain() always sets the prototype option in its deepEqual() invocation.
In code it is always called with option and a value for prototype.
In joi it is always called without options.

Note, there is still a case where the option is unset, where you might expect it to be the default value:

Hoek.deepEqual(Object.create(null), {}, { prototype: undefined });

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.