hapijs / hoek

Node utilities shared among the extended hapi universe
Other
480 stars 171 forks source link

react-scripts upgrade to 3.0.0 breaks build #309

Closed ingeborgclose closed 5 years ago

ingeborgclose commented 5 years ago

/workspace/node_modules/@hapi/hoek/lib/deep-equal.js:17

    options = { prototype: true, ...options };

SyntaxError: Unexpected token ... at Object.exports.runInThisContext (vm.js:76:16) at Module._compile (module.js:542:28) at Object.Module._extensions..js (module.js:579:10) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.require (module.js:497:17) at require (internal/module.js:20:19) at Object. (/var/lib/jenkins/jobs/flow-gui-pipeline/branches/PR-82/workspace/node_modules/@hapi/hoek/lib/index.js:9:19) at Module._compile (module.js:570:32) at Object.Module._extensions..js (module.js:579:10) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.require (module.js:497:17) at require (internal/module.js:20:19)

ingeborgclose commented 5 years ago

`npm run build npm info it worked if it ends with ok npm info using npm@3.10.10 npm info using node@v6.9.5 npm info lifecycle flow-gui@0.1.0~prebuild: flow-gui@0.1.0 npm info lifecycle flow-gui@0.1.0~build: flow-gui@0.1.0

> flow-gui@0.1.0 build /var/lib/jenkins/jobs/flow-gui-pipeline/branches/PR-82/workspace > react-scripts build

/var/lib/jenkins/jobs/flow-gui-pipeline/branches/PR-82/workspace/node_modules/@hapi/hoek/lib/deep-equal.js:17 options = { prototype: true, ...options }; ^^^ SyntaxError: Unexpected token ... at Object.exports.runInThisContext (vm.js:76:16) at Module._compile (module.js:542:28) at Object.Module._extensions..js (module.js:579:10) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.require (module.js:497:17) at require (internal/module.js:20:19) at Object. (/var/lib/jenkins/jobs/flow-gui-pipeline/branches/PR-82/workspace/node_modules/@hapi/hoek/lib/index.js:9:19) at Module._compile (module.js:570:32) at Object.Module._extensions..js (module.js:579:10) at Module.load (module.js:487:32) at tryModuleLoad (module.js:446:12) at Function.Module._load (module.js:438:3) at Module.require (module.js:497:17) at require (internal/module.js:20:19)

npm info lifecycle flow-gui@0.1.0~build: Failed to exec build script npm ERR! Linux 4.4.0-150-generic npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build" npm ERR! node v6.9.5 npm ERR! npm v3.10.10 npm ERR! code ELIFECYCLE npm ERR! flow-gui@0.1.0 build: react-scripts build npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the flow-gui@0.1.0 build script 'react-scripts build'. npm ERR! Make sure you have the latest version of node.js and npm installed. npm ERR! If you do, this is most likely a problem with the flow-gui package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! react-scripts build npm ERR! You can get information on how to open an issue for this project with: npm ERR! npm bugs flow-gui npm ERR! Or if that isn't available, you can get their info via: npm ERR! npm owner ls flow-gui npm ERR! There is likely additional logging output above.`

WesTyler commented 5 years ago

using node@v6.9.5

Node.js v6.x is no longer maintained. Hoek only supports Node.js LTS versions, which are currently 8.x and 10.x release lines.

ingeborgclose commented 5 years ago

Thanks!

anuraghakeem commented 5 years ago

npm: '6.9.2', ares: '1.10.1-DEV', cldr: '31.0.1', http_parser: '2.7.0', icu: '59.1', modules: '57', node: '8.1.3', openssl: '1.0.2l', tz: '2017b', unicode: '9.0', uv: '1.12.0', v8: '5.8.283.41', zlib: '1.2.11'

These are my specs, yet it shows the same error

Marsup commented 5 years ago

You need >= 8.6.0.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.