applyToDefaults() does not respect nullOverride when shallow is used - Githubissues

hapijs / hoek

Node utilities shared among the extended hapi universe

Other

481 stars 171 forks source link

applyToDefaults() does not respect nullOverride when shallow is used #366

Closed kanongil closed 3 years ago

kanongil commented 3 years ago

Support plan

is this issue currently blocking your project? (yes/no): no
is this issue affecting a production system? (yes/no): not that I know

Context

node version: any
module version with issue: 9.1.0
last module version without issue: 6.x
environment (e.g. node, browser, native): node
used with (e.g. hapi application, another framework, standalone, ...): standalone
any other relevant information: Based on discussion in #365.

What are you trying to achieve or the steps to reproduce?

Use method with nullOverride and shallow:

const defaults = { host: "localhost", port: 8000 };
const source = { host: null, port: 8080 };

Hoek.applyToDefaults(defaults, source, { nullOverride: true });
// Works - results in { host: null, port: 8080 }

Hoek.applyToDefaults(defaults, source, { nullOverride: true, shallow: [] });
// Fails - results in { host: "localhost", port: 8080 }

What was the result you got?

Any shallow changes the result when nullOverride: true.

What result did you expect?

Always respect nullOverride: true.