search

hapijs / hoek

Node utilities shared among the extended hapi universe
Other
481 stars 171 forks source link

fix: expose AssertError #381

Closed Marsup closed 1 year ago

Marsup commented 2 years ago

I noticed Error is not exposed in the typescript types, I found it weird to export a variable that would be shadowing the global Error, I thought it was a better idea to have a proper name so we can slowly transition to that to avoid any further confusion, let me know what you think.

Marsup commented 2 years ago

Sure, we can also go straight for the breaking change, that was not my goal here, but it's indeed better. Is it still worth having a final 10.x release with that type fix or not even?

devinivy commented 1 year ago

@Marsup if v10 and v11 were significantly different or had different nodejs requirements, I might suggest landing the type fix in v10 before moving onto v11. But in this case I think it's fine to skip straight to the changes in #382.

Marsup commented 1 year ago

@devinivy I only cared about it for joi, if the issue was not raised before, I'm fine moving on to the next major.