Email validation error in v17.8.1 - Githubissues

hapijs / joi

The most powerful data validation library for JS

Other

20.95k stars 1.51k forks source link

Email validation error in v17.8.1 #2915

Closed vmarannan closed 1 year ago

vmarannan commented 1 year ago

Support plan

is this issue currently blocking your project? (yes/no): no
is this issue affecting a production system? (yes/no): no

Context

node version: v18.0
module version: v17.8.1
environment (e.g. node, browser, native): browser
used with (e.g. hapi application, another framework, standalone, ...): hapi
any other relevant information:

What are you trying to achieve or the steps to reproduce?

Schema

Joi.object({
  email: Joi.string()
        .email({ tlds: { allow: false } })
})

Data To Validate

{ 
  email: 'somevalid@email.com'
}

Result

TypeError: Cannot read properties of undefined (reading 'has')

What result did you expect?

Validate without error as stated on https://joi.dev/api/?v=17.8.1#stringemailoptions

charleskoehl commented 1 year ago

I'm getting same with v17.8.1 and v17.8.0 and the same schema:

Joi.object({
  email: Joi.string()
        .email({ tlds: { allow: false } })
})

Fixed by pinning at 17.7.1.

Bug must have been caused by https://github.com/hapijs/joi/pull/2909

Marsup commented 1 year ago

This is fixed in 17.8.2.