search

hapijs / joi

The most powerful data validation library for JS
Other
20.94k stars 1.51k forks source link

feat: Support encoding uri #3027

Closed HYOSITIVE closed 7 months ago

HYOSITIVE commented 7 months ago

Related Issue

About Changes

Result

Screenshot 2024-03-30 at 9 26 29 PM
Marsup commented 7 months ago

Looks like you also need to test for convert: false as true is already the default. It's also missing a bit of docs but I can do it if you don't want to. Thanks for your contribution!

HYOSITIVE commented 7 months ago

@Marsup Thanks for the review! I will add a test case for convert: false. Besides that, could you let me know which docs did I miss? I can add those as well.

Marsup commented 7 months ago

Just missing a quick description in https://github.com/hapijs/joi/blob/5b96852fe07a742a8733f2bff1303d50853ca65c/API.md#L3084-L3089

HYOSITIVE commented 7 months ago

Sorry for the delay. Just updated the PR!

Marsup commented 7 months ago

I'll change it a bit before releasing for some edge cases, but this is good to go, thanks!

HYOSITIVE commented 7 months ago

Thanks, @Marsup! Please close the issue as well. I don't have a permission to do that because I'm not the one who opened it.

Marsup commented 7 months ago

It's published.