Closed binarymist closed 5 years ago
I downgraded lab, and problem persists, so seems that the issue is with eslint.
No, cache was dirty, issue is still with lab, in fact it looks most likely to be due to the espree upgrade
lab 16.0.0 is using two versions of espree. As seen in package-lock.json
"lab": {
"version": "16.0.0",
"resolved": "https://registry.npmjs.org/lab/-/lab-16.0.0.tgz",
"integrity": "sha512-RiJYiGzaphEkQeoaENJevdBArwuQOil4p7azwGtLDz58/g/TtbAAODsP/ECQPmXkNORkkHd2WK8CNf9hG8iI+g==",
"dev": true,
"requires": {
"bossy": "4.x.x",
"diff": "3.5.x",
"eslint": "5.4.x",
"eslint-config-hapi": "12.x.x",
"eslint-plugin-hapi": "4.x.x",
"espree": "4.0.x",
"find-rc": "3.0.x",
"handlebars": "4.x.x",
"hoek": "5.x.x",
"json-stable-stringify": "1.x.x",
"json-stringify-safe": "5.x.x",
"mkdirp": "0.5.x",
"seedrandom": "2.4.x",
"source-map": "0.6.x",
"source-map-support": "0.5.x",
"supports-color": "4.4.x",
"will-call": "1.x.x"
},
"dependencies": {
"espree": {
"version": "3.5.4",
"resolved": "https://registry.npmjs.org/espree/-/espree-3.5.4.tgz",
"integrity": "sha512-yAcIQxtmMiB/jL32dzEp2enBeidsB7xWPLNiw3IIkpVds1P+h7qF9YwJq1yUNzp2OKXgAprs4F61ih66UsoD1A==",
"dev": true,
"requires": {
"acorn": "^5.5.0",
"acorn-jsx": "^3.0.0"
...
Tried:
"resolutions": {
"espree": "^4.0.x"
},
but acorn is then missing. Reverting back to old lab version until fixed.
I was unable to reproduce in hapi with lab master (soon to be released lab 18), which is using a centralized ecmaFeatures
when calling into espree/eslint.
Feel free to open this up again if you encounter the issue again.
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.
When I run
lab --assert code
: no problem When I ranlab --assert code --coverage
before upgrading from "eslint": "^4.19.1", "lab": "^15.5.0" : no problemAfter upgrade: When I run
lab --assert code --coverage