hapijs / nes

WebSocket adapter plugin for hapi routes
Other
503 stars 87 forks source link

Access to remote address in onSubscribe and onUnsubscribe #209

Closed salehe closed 6 years ago

salehe commented 6 years ago

It is useful to have some information about the connection in these functions.

It seems that access to connection information via socket parameter was introduced in https://github.com/hapijs/nes/commit/71e9232bb84ad30ab0a5f62647b07144d44e2930 , but was later removed.

mtharrison commented 6 years ago

Perhaps a socket.info object would be useful, similar to hapi's request.info.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.