search

hapijs / nes

WebSocket adapter plugin for hapi routes
Other
502 stars 87 forks source link

Nes won't try to reconnect on a websocket error #242

Closed mtharrison closed 6 years ago

mtharrison commented 6 years ago

When onerror is called on the client Websocket object we do not try to reconnect. This seems like an oversight. We try to reconnect if the connection goes away in other cases but not on error.

mtharrison commented 6 years ago

Out of curiosity I checked socket.io's behaviour in the same situation and it will attempt to reconnect.

hueniverse commented 6 years ago

Sounds like an oversight.

mtharrison commented 6 years ago

Closed #247

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.