hapijs / nes

WebSocket adapter plugin for hapi routes
Other
502 stars 87 forks source link

Close the socket when authentication expires #260

Closed dominykas closed 5 years ago

dominykas commented 5 years ago

When a websocket requires authentication, and the server uses some sort of token based authentication, the credentials usually have a limited lifetime. The nes clients are free to overrideReconnectionAuth() and provide new credentials for the case when the websocket drops, however if the websocket does not drop - it still assumes the old credentials on the server side. This means that the websocket is open to send/receive information even though the client may no longer have valid credentials, which could be a security issue in some contexts.

Proposal

hueniverse commented 5 years ago

@dominykas This is mostly done now. Need to update the API doc. Requires hapi v17.8.1 which is reflected in the plugin requirements.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.