search

hapijs / nes

WebSocket adapter plugin for hapi routes
Other
503 stars 87 forks source link

Fix tests #277

Closed hueniverse closed 5 years ago

hueniverse commented 5 years ago

Tests all pass consistently locally but fail inconsistently on travis. This is probably due to slow test env and delicate timing issues in the tests.

saboya commented 5 years ago

Not sure about random failures, but 83) Client request() errors on invalid payload: will fail on recent versions of node because of this change on v8: https://github.com/v8/v8/commit/eb18edb4f55cd425c14de088b46880ec211b0812

The error message either has to be updated or changed to a RegExp test to match the start of the string.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.