cleanup called twice if there is an onUnsubscribe handler

hapijs / nes

WebSocket adapter plugin for hapi routes

Other

502 stars 87 forks source link

cleanup called twice if there is an onUnsubscribe handler #283

Closed lerouxb closed 5 years ago

lerouxb commented 5 years ago

https://github.com/hapijs/nes/blob/9f9f0c06809cacac018a71aa637f61d8c8c2bcd0/lib/listener.js#L539-L547

Would probably be OK if the code was synchronous, but there's an await in between.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.