Closed rankida closed 5 years ago
I am going to blame Travis for the failing builds.
This PR now has the same success (or a little more) than master
appears to have.
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.
In cases where there is an
onUnsubscribe
handler registered it is possible thatrevoke
can be called on a socket that has since been closed. This results in an error being thrown.To prevent having to try/catch and explicitly test for
nes
's internalSocket not open
error this new flagthrowIfClosed
allows the user to signal their intent to "fire and forget".Because
revoke
is async internally it is not possible to catch this with certainty prior to making therevoke
call.The added tests demonstrate the issue we are seeing in production.