search

hapijs / yar

A hapi session manager
Other
133 stars 59 forks source link

Custom Session ID #104

Closed hishayness closed 8 years ago

hishayness commented 8 years ago

Hello!

Looking through the source code, I don't see a way to provide a custom session id. I was looking into layering multiple security hashes to the id to allow some extended functionalities (eg. dropping certain sets of session ids from persistent store). I was wondering if this was perhaps somewhere down in the roadmap or not something that yar was intended to ever support out of the box?

mark-bradshaw commented 8 years ago

PRs gratefully accepted. :)

sirgallifrey commented 8 years ago

I think I can help with that, can I work on this issue?

mark-bradshaw commented 8 years ago

Of course @sirgallifrey

sirgallifrey commented 8 years ago

almost done, but there is a issue that bothers me. If we let the dev assign any ID that he wants, that will allow duplicated ids... Is that something that I have to prevent or it will be the developer's responsibility?

mark-bradshaw commented 8 years ago

Dev responsibility I'd say. They might do it on purpose.

mark-bradshaw commented 8 years ago

Implemented in #106. Published as v8.1.0

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.