hapijs / yar

A hapi session manager
Other
133 stars 59 forks source link

session duration #77

Closed mark-bradshaw closed 9 years ago

mark-bradshaw commented 9 years ago

@OmniJeff Any reservations to a PR making the session duration configurable?

hueniverse commented 9 years ago

You can already set how long the cookie should last and how long the session information is saved in the cache. What else do you need?

Also, please don't assign tasks to other people.

mark-bradshaw commented 9 years ago

I didn't see that in the docs. Am I missing it, or do the docs need updating.

On Sun, Aug 30, 2015 at 7:01 PM Eran Hammer notifications@github.com wrote:

You can already set how long the cookie should last and how long the session information is saved in the cache. What else do you need?

— Reply to this email directly or view it on GitHub https://github.com/hapijs/yar/issues/77#issuecomment-136219464.

hueniverse commented 9 years ago

No idea. You can see it in the code...

mark-bradshaw commented 9 years ago

So looking at the code, I'd use the cookie options config section to set a duration. The other duration is for server storage, so that's not necessarily what I want. I'll do some experimentation, and maybe send in a PR to update docs if I'm right.

hueniverse commented 9 years ago

Sounds good.

lock[bot] commented 4 years ago

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.