search

hapipal / boilerplate

A friendly, proven starting place for your next hapi plugin or deployment
https://hapipal.com
184 stars 26 forks source link

prefer npm ci over npm i #101

Closed jameswragg closed 11 months ago

jameswragg commented 11 months ago

Re #100

jameswragg commented 11 months ago

I would guess this to be a mismatch of npm package-lock.json versions.Things to try:1. Re-create your package-lock2. Match local npm versions to the container or,3. Update node base image in DockerfileOn 11 Dec 2023, at 10:20 am, Jonas Pauthier @.***> wrote: @Nargonath commented on this pull request.

The changes LGTM. I tested a npm run build:web locally and it failed. Here is the result: image.png (view on web) Not sure what the root cause. I have dug into it.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Nargonath commented 11 months ago

Yeah that's what I thought as well. The image is still using node 14 so we should probably upgrade it anyway.

jameswragg commented 11 months ago

@Nargonath do you want me to update the base image in this PR? If so, the current LTS (20)?