hapipal / boilerplate

A friendly, proven starting place for your next hapi plugin or deployment
https://hapipal.com
184 stars 26 forks source link

anything you'd do different? #34

Closed jamesdixon closed 7 years ago

jamesdixon commented 7 years ago

Hi,

I just stumbled upon your boilerplate -- is there anything you'd do differently since this was last updated?

Cheers!

devinivy commented 7 years ago

Hi! Glad you found it! Good question. We are actually in the process of packaging this boilerplate up into a more flexible and robust solution, and planning on supporting it more actively. The pal branch is in a good state right now– that's what I would suggest going with. That branch is a much more "vanilla" version of the boilerplate– no dogwater, swagger, etc.– but in the next couple of weeks we're going to provide addons that make it easy to pull-in common features.

jamesdixon commented 7 years ago

@devinivy thanks for the quick reply! I just attempted to use git clone --depth=1 --origin=pal git@github.com:devinivy/boilerplate-api.git my-project to pull down the pal branch, but unfortunately, I'm just getting a permissioning error:

Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
jamesdixon commented 7 years ago

FWIW, cloning over HTTPS worked 👍

jamesdixon commented 7 years ago

Ok, I lied. It cloned, but it appears to be pulling in master rather than the pal branch.

jamesdixon commented 7 years ago

@devinivy are flavors active yet?

devinivy commented 7 years ago

Good to know! Do you use ssh/keys with other repos? Flavors aren't active yet, but the schwifty/objection one will be the first one we put up!

jamesdixon commented 7 years ago

Yes sir, I do use SSH/Keys with other repos

mattboutet commented 7 years ago

I'm able to replicate this issue from a shell session that doesn't have a key associated with a github account, but even for an account that doesn't have any special access to this repo, I can clone via ssh.

@jamesdixon - if you do ssh -T git@github.com, does it succeed? If not, what does ssh -vT git@github.com output? (apologies if this seems simplistic, I don't want to make assumptions)

jamesdixon commented 7 years ago

@mattboutet thanks for the response. I'm not sure what the hell happened, but indeed my SSH key was missing from Github. Sorry to waste your time, but thanks for pointing me down the right path. Cheers!

devinivy commented 7 years ago

Glad all's clear. By the way, to actually pull down the pal branch, you'll want this,

git clone --depth=1 --origin=pal --branch=pal git@github.com:devinivy/boilerplate-api.git my-project

All I added was --branch=pal, which will not be necessary in the future.

devinivy commented 7 years ago

@jamesdixon in case you're looking for the objection/schwifty setup, here's a decent start: https://github.com/devinivy/boilerplate-api/commit/f1bf9bb4b6ffd4175ad33f3a4117f6bb8f19d8ec

jamesdixon commented 7 years ago

@devinivy you read my mind! THANK YOU!