search

hapipal / boilerplate

A friendly, proven starting place for your next hapi plugin or deployment
https://hapipal.com
184 stars 26 forks source link

added dev dependency #40

Closed bmleight closed 7 years ago

bmleight commented 7 years ago

Found this while doing some stuff for kegbot. Hopefully I'm submitting it right. Also, just to note, swagger moving from /swagger to /documentation confused me longer than it should have.

devinivy commented 7 years ago

Hey, thanks for catching this. Do you mind updating this so that the "swagger" dependency is removed? I think I added swagger instead of hapi-swagger.

devinivy commented 7 years ago

@mattboutet to your knowledge the swagger package isn't required for hapi-swagger, right? 95% sure that was just a typo on my part.

mattboutet commented 7 years ago

hapi-Swagger isn't peer-dependent on Swagger, so it's totally fine to axe Swagger and leave it as just hapi-Swagger

devinivy commented 7 years ago

Beauteous!

bmleight commented 7 years ago

I tested it and everything! Anything to my confusion with the route swagger is served on (/swagger vs /documentation)? I guess I'm wondering if this should be pointed out in the docs somewhere, or if I'm just n3wbing out?

devinivy commented 7 years ago

Probably makes sense to add this to the docs around that flavor. It moved because we used to override the default.