search

hapipal / boilerplate

A friendly, proven starting place for your next hapi plugin or deployment
https://hapipal.com
183 stars 27 forks source link

Add Sequelize support as flavor #51

Closed Nargonath closed 5 years ago

Nargonath commented 6 years ago

I saw that you offer knex and objection support but what do you think of adding Sequelize support as flavor as well?

I could definitely look into making a PR if that's something you'd consider.

Thanks for the great project.

devinivy commented 6 years ago

A flavor is simply a single commit that can be cherry-picked into a project, so it's a piece of cake to use flavors from all different sources through git. We maintain a branch for each flavor, then when it's time to release, we just squash the whole branch down into a single commit and tag it so that can be cherry-picked easily.

I'd be happy to document our flavor release process and keep a list of community flavors that work nicely with the pal boilerplate, if you're interested in maintaining a sequelize flavor on a fork of the pal boilerplate 👍

Nargonath commented 6 years ago

Interesting I would have never thought of such solution. I'm not sure I fully grasp it yet but I'll definitely look into making such flavor.

devinivy commented 6 years ago

This conversation continued in slack. For those interested in maintaining their own flavors, here is the manual release process https://gist.github.com/devinivy/d0d403c85ba8e2b1eb59f01a6b497a24

Nargonath commented 5 years ago

Yeah sorry I forgot about this issue. In fact we are considering migrating to Objection so we can use hpal 😃

devinivy commented 5 years ago

Hey, no problem! While I think that is great news for you and your team, I also hope like you don't feel like you have to use Objection in order to take advantage of all the other tools and patterns that are a part of hapi pal. Here's an example in the haute-couture docs that shows how to use another ORM (in this case, Mongoose) with haute-couture and the hpal CLI: https://github.com/hapipal/haute-couture/blob/master/API.md#amendment-example

Nargonath commented 5 years ago

Yeah you are right, we don't feel like we have to. We are always happy to try something new as well so we can better assess what we like best and why. Thanks for the resource.