search

hapipal / boilerplate

A friendly, proven starting place for your next hapi plugin or deployment
https://hapipal.com
183 stars 27 forks source link

Update deps #58

Closed zemccartney closed 6 years ago

zemccartney commented 6 years ago

Takes care of bumping a few dependencies

@devinivy only sorta inconsistency I saw was a deprecated config setting in eslint. You see this message on linting the project w/ our lint script:

[ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in ".eslintrc.json")

Note, this message doesn't pop up when you run lab and lab uses the same version of eslint.

And the only reason I kept eslint at 5.4.x was to match lab's setting. Dunno if that's desired! my bad if not

devinivy commented 6 years ago

Regarding the eslint warning, if we can make a more up-to-date eslintrc file than lab, then that's fine with me. It might be that we should get rid of ecmaFeatures and bump ecmaVersion to 9.

devinivy commented 6 years ago

(And if so, it would also be friendly to propose that change upstream in lab!)

zemccartney commented 6 years ago

yo! yup, that was exactly it. updated the eslintrc file, will do in the other flavors and will send a note to lab. thanks, homie! 🙏