search

hapipal / boilerplate

A friendly, proven starting place for your next hapi plugin or deployment
https://hapipal.com
184 stars 26 forks source link

Update objection flavor deps #59

Closed zemccartney closed 6 years ago

zemccartney commented 6 years ago

knex was the only dependency change. I don't think anything in that update affects us, even though some breaking changes

1 odd thing here: test script modified to have no timeout; the single test was failing due to timing out; on my machine, test took consistently 3.5 seconds or so. @devinivy thoughts on this? felt band-aidy; sorry!

devinivy commented 6 years ago

I would like to investigate the timeout issue! You're right, that is pretty band-aidy. So the tests do pass (with these changes) but take 3.5 seconds? Definitely sounds like something is up. Maybe debug together later?

zemccartney commented 6 years ago

mm! yea, that'd be good. i'll bug ya later. thanks, dude! 🙏