search

hapipal / boilerplate

A friendly, proven starting place for your next hapi plugin or deployment
https://hapipal.com
183 stars 27 forks source link

ES6 upgrades using strict, moving var > const and updates setting the URI #6

Closed maxfelker closed 8 years ago

maxfelker commented 8 years ago

I found that the project was still using var and not following some ES6 patterns. Also updated the readme.

maxfelker commented 8 years ago

Hey @devinivy @mattboutet take a look at this and let me know your thoughts!

mattboutet commented 8 years ago

@maxatbrs -- this all looks fine to me. I'd actually done a lot of this on LH, but never got around to backporting it to the boilerplate, so thanks.

I'm (slowly) coming around to appreciating arrow syntax for callbacks, and if we're going to es6-ify this, it seems like it might make sense to do that as well. Unless you or @devinivy really hate the arrow syntax.

mattboutet commented 8 years ago

@maxatbrs - I've merged this into my fork, and I have an updated Lab running the Hapi eslint ruleset there. I'll want to get it it passing the linter cleanly before updating, so I can handle the handful of spots that want conversion to arrow syntax.