hapipal / boilerplate

A friendly, proven starting place for your next hapi plugin or deployment
https://hapipal.com
184 stars 26 forks source link

Replace nodemon command glob patterns with directory names #93

Closed erin-doyle closed 4 years ago

erin-doyle commented 4 years ago

This fixes issue #92 .

Docker log output shows:

[nodemon] 2.0.4
[nodemon] to restart at any time, enter `rs`
[nodemon] watching path(s): lib/**/* server/**/*
[nodemon] watching extensions: js,mjs,json
[nodemon] starting `node server/index.js`
Server started at http://0.0.0.0:3000
devinivy commented 4 years ago

@timcosta if you have a moment to take a look that would be 👍 . If not, of course no worries.

timcosta commented 4 years ago

Apologies for the delay, nutty couple of days. This looks good to me, no clue why I've never had an issue with this over the last year or two. I've found nodemon to be a little unpredictable though, so it wouldn't surprise me if there's some edge case occurring.

devinivy commented 4 years ago

@timcosta no problem at all, thanks for taking a look 👍 I also haven't had this issue, but either way I'm glad to move things to be more in line with the current nodemon docs.

erin-doyle commented 4 years ago

Thanks guys! I'm trying to think of what could cause the discrepancy. The line in the nodemon docs about not using glob patterns was added as far back as 2015 (https://github.com/remy/nodemon/commit/782b74dd3eef72eb14c5a211f333d03e65b510e5). The only thing I can think of is maybe the alpine version changed from when you guys last built a container and now which may have allowed the globing to work previously but now doesn't? Other than that I have no clue... 🤷‍♀️

devinivy commented 4 years ago

So strange! In any case, thanks again for the fix! I'm sure you weren't (or wouldn't have been) the only one affected by it.