search

hapipal / confidence

Dynamic, declarative configurations
Other
264 stars 44 forks source link

Add indentation option to CLI #39

Closed SimonDegraeve closed 9 years ago

patrickkettner commented 9 years ago

great idea! there are some issues with the tests, however. Could you look into it?

It may also be worthwhile to do a check to ensure its a number, and not a string

SimonDegraeve commented 9 years ago

I will look at those tests later. Need to catch a flight now.

patrickkettner commented 9 years ago

Sounds great – safe travels

On Wed, Jul 29, 2015, 1:47 AM Simon Degraeve notifications@github.com wrote:

I will look at those tests later. Need to catch a flight now.

— Reply to this email directly or view it on GitHub https://github.com/hapijs/confidence/pull/39#issuecomment-125849986.

SimonDegraeve commented 9 years ago

Back on the ground ;-) I added some tests, it should be ready to be merged.

SimonDegraeve commented 9 years ago

PS: Is there a way to test on travis from the local repo before commit? Because the tests have passed on my computer, and turns out they failed in travis...

devinivy commented 9 years ago

I'd suggest making sure you have the latest version of lab.

SimonDegraeve commented 9 years ago

lab 5.14.0 (latest) node 0.12.7 (latest)

And when running the tests, the package doesn't use a global version of lab anyway it is the one from package.jsonwhich is the latest...

So I guess there is no magic trick that I am not aware of like pre-test on remote before commit...

SimonDegraeve commented 9 years ago

I mean I know you can use git hooks for that, but I am just curious is there is something else I don't know.

patrickkettner commented 9 years ago

@SimonDegraeve there is not a way to test on travis, per se. If I had to guess, you were testing on a single version of node and it was failing on the other?

either way - great work!