search

hapipal / confidence

Dynamic, declarative configurations
Other
264 stars 44 forks source link

$base keyword works for arrays with concatenation #43

Closed netei closed 9 years ago

netei commented 9 years ago

See #42

patrickkettner commented 9 years ago

:+1:

tanepiper commented 9 years ago

@patrickkettner @netei This commit has completely broken my build! My package.json has ^1.2.0 for confidence, and all of a sudden things were breaking:

Getting this error

Error: Cannot merge array onto an object
    at Object.exports.assert (.\node_modules\confidence\node_modules\hoek\lib\index.js:723:11)
    at Object.exports.merge (.\node_modules\confidence\node_modules\hoek\lib\index.js:97:17)
    at Object.internals.defaults (.\node_modules\confidence\lib\store.js:83:21)
    at Object.internals.filter (.\node_modules\confidence\lib\store.js:129:26)
    at Object.internals.walk (.\node_modules\confidence\lib\store.js:192:31)
    at internals.Store.get (.\node_modules\confidence\lib\store.js:33:22)
    at generateConfig (.\index.js:32:29)
    at Object.<anonymous> (.\index.js:40:1)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)

Looks like you're change is causing this to fail in hoek:

https://github.com/hapijs/hoek/blob/master/lib/index.js#/L96

netei commented 9 years ago

Right, #44 fixes your error