search

hapipal / confidence

Dynamic, declarative configurations
Other
263 stars 43 forks source link

Move codebase to Node 4 #48

Closed augnin closed 8 years ago

augnin commented 8 years ago

not the best time for a PR.. merry xmas guys and a very happy new year.

not sure if it was planned, but this PR moves the existing code base to Node 4 and drop support for previous version of node.

augnin commented 8 years ago

@Marsup added suggested changes

gergoerdosi commented 8 years ago

Any reason this is not merged yet?

gergoerdosi commented 8 years ago

@patrickkettner: We rely on this module in many of our projects. We would like to make sure it is maintained and works with all the recent node versions. If anything blocks these changes from being merged, please let me know and I will send an other pull request.

lloydbenson commented 8 years ago

@gergoerdosi I was able to get a hold of @patrickkettner and he said he should be able to take care of this soon (tuesday). He has just been busy with a newborn ;)

gergoerdosi commented 8 years ago

Thanks for the information @lloydbenson. Congrats @patrickkettner!

patrickkettner commented 8 years ago

Sorry again, everyone. Diving into this now

patrickkettner commented 8 years ago

just one tiny change, and then we can merge and release. Sorry again for this taking forever

augnin commented 8 years ago

@patrickkettner : added suggested change

patrickkettner commented 8 years ago

published as 3.0.0