search

hapipal / confidence

Dynamic, declarative configurations
Other
264 stars 44 forks source link

Update regarding invalid characters in keys #60

Closed ryankeener closed 8 years ago

ryankeener commented 8 years ago

We ran into this issue where we were unknowingly using disallowed characters in our keys and the config was failing 'silently' (i.e. it was returning undefined on .get but otherwise not alerting us to the error of our ways 😄 )

patrickkettner commented 8 years ago

hey @ryankeener!

out of curiosity, what keys are you using that have a . in them? It seems like this could cause confusion easily since that is the normal separator for terms in JSON style notation.

ryankeener commented 8 years ago

@patrickkettner We may have a somewhat unique use case where we are storing configuration related to paths so it's quite handy for us to use those (dot-separated) paths as keys since Confidence uses the / separator.

patrickkettner commented 8 years ago

Hey @ryankeener! So I really appreciate the work going into the PR, but we are going to maintain our current style and not allow for dot separated keys. You can certainly move this type of data over to the value section, on a key called $path or something similar.

As a result, im going to close this. For now. If others are interested in the feature, please do comment here so we can reconsider in the future.