Support for default criteria

[federicojasson]

It would be useful to be able to define a default criteria.

Currently, when one calls get without a criteria, {} is used by default. I find myself repeating the same criteria every time I have to get a path:

store.get('/a/b', { env: process.env.NODE_ENV });

...

// At some other place
store.get('/c', { env: process.env.NODE_ENV });

If the criteria is more complex, things get more tedious. My workaround is to simply get the root config once and use that everywhere, but that eliminates the advantages of the get function.

[patrickkettner]

+1 for the feature idea. If anyone wants to implement before I get a chance to, I'll be happy to review/merge.

[federicojasson]

In order to keep backward compatibility, interfaces could be changed to:

---

new Store([document], [defaultCriteria])

By default, defaultCriteria is {}.

---

store.load(document, [defaultCriteria])

By default, defaultCriteria is {}.

---

store.get(key, [criteria])

By default, criteria is defaultCriteria.

---

store.meta(key, [criteria])

By default, criteria is defaultCriteria.

---

This way, if defaultCriteria is not passed, {} will used as the default criteria (as before).

[ryanwilliamquinn]

You could achieve this through partial application too, not sure this is enough of a solution:

const confidence = require('confidence')
const _ = require('lodash')
const manifest = {
  mykey: {
    $filter: 'env',
    production: 'prod',
    development: 'dev',
    $default: 'dflt'
  }
}
const criteria = {
  env: process.env.NODE_ENV
}
const store = new confidence.Store(manifest)
const storeGet = _.partialRight(store.get.bind(store), criteria)
console.log(`get mykey: ${storeGet('/mykey')}`)

[augnin]

you can do this by extending the Store class

const { Store } = require('confidence');
const Hoek = require('hoek');

module.exports = class extends Store {

    get(key, criteria) {

        return super.get(key, Hoek.applyToDefaults({ env: process.env.NODE_ENV }, criteria || {}));
    }
};

[augnin]

with $env feature, you can refer to environment variables in the store itself, without the need to pass them in criteria.

https://github.com/hapijs/confidence#filters