search

hapipal / hpal

hapi pal CLI
https://hapipal.com
MIT License
51 stars 7 forks source link

Support multi-plugin projects #9

Closed devinivy closed 6 years ago

devinivy commented 6 years ago

See #8 for details

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ce797993ca0ff9b97f08f9625f1db4b605c34645 on multi-plugin-project into dbef672f4970ead5e9df25b84e38ff7e04d2d1b9 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ce797993ca0ff9b97f08f9625f1db4b605c34645 on multi-plugin-project into dbef672f4970ead5e9df25b84e38ff7e04d2d1b9 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ce797993ca0ff9b97f08f9625f1db4b605c34645 on multi-plugin-project into dbef672f4970ead5e9df25b84e38ff7e04d2d1b9 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling a87188e525a76b5c0b66b84b5c03508d32c234a0 on multi-plugin-project into dbef672f4970ead5e9df25b84e38ff7e04d2d1b9 on master.

zemccartney commented 6 years ago

not much of anything to say, sorry 🚬 :trollface: this looks super cool. thanks for thinking about this and drumming this up. 🙏

devinivy commented 6 years ago

Thanks for taking a good look at this @zemccartney !

As discussed off github, we may want to take a slightly different approach to handle a case like this one,

lib/
    .hc.js
    plugins/          <-- cwd
        sub-plugin/
            .hc.js

Under the old behavior it would correctly (I think) choose lib/ as our working plugin. Under the behavior in this PR it would start to choose sub-plugin/. Will be thinking on it!

devinivy commented 6 years ago

Replaced by #10.