search

hapipal / schwifty

A model layer for hapi integrating Objection ORM
MIT License
73 stars 10 forks source link

Drop Node 10, etc. #94

Closed Nargonath closed 3 years ago

Nargonath commented 3 years ago

This is a breaking change too.

Nargonath commented 3 years ago

this is linked to #92

Nargonath commented 3 years ago

@devinivy knex@21 drop support for Node 8. Do we want to bump the peerDep to v21 as well?

Nargonath commented 3 years ago

Also now the PR fixes #92

devinivy commented 3 years ago

Thanks @Nargonath! I think we'll leave the knex peer dep at v0.16 for now, since that version did eventually support node v12 (and there's no feature in future versions that I anticipate schwifty needing).

Nargonath commented 3 years ago

You're welcome @devinivy. If we keep knex as is there shouldn't be any more work required on this PR otherwise please let me know and I'll do whatever is required. 👍

devinivy commented 3 years ago

This looks good— going to roll it into the new v6 branch and keep working from here. Thanks again 👍

Nargonath commented 3 years ago

You're welcome. 😉