search

haplokuon / netDxf

.net dxf Reader-Writer
MIT License
986 stars 400 forks source link

Make PolylineVertex Flags public please, because we want to filter vertices #308

Closed framlingham closed 2 years ago

framlingham commented 3 years ago

We want to filter to just SplineVertexFromSplineFitting points please. This will let us get the points we want without changing the code much. But is this the right way? Would you like to keep the setter Internal? I can update the pull request if you want.

haplokuon commented 3 years ago

The thing here is that polyline smoothing is not implemented, the information from the DXF is read but you cannot edit them, you can break the polyline if you do not set the flags properly. Also the VertexTypeFlags are actually shared between three different entities the old 2dPolyline that is imported as LwPolyline, the 3dPolyline (Polyline) and the polyface mesh (PolyfaceMesh).

It is not a problem to give read access to those flags, but you should keep them as read only.

framlingham commented 2 years ago

I see we can use PolygonalVertexes now. Thanks.