haplokuon / netDxf

.net dxf Reader-Writer
MIT License
1.01k stars 411 forks source link

Support .net standard 2.0 #379

Closed ikorin24 closed 2 years ago

ikorin24 commented 2 years ago

Is it possible to support .net standard 2.0, just by adding netstandard2.0 to TargetFrameworks in netDxf.csproj?

This will allow you to use all .net framework versions up to .net framework 4.8.

haplokuon commented 2 years ago

Sorry but I will not provide compiled versions of this library anymore only as source code and I am not related in anyway with the available nuget downloads. Once in a while someone comes asking if I can include a specific net version, the code is here everybody can easily modify the proj file to fit anyone needs. I cannot include every single net version that this library is compatible with, too many,, only main version upgrades and specially those that require some attention.

The only three things to take care are the two defined conditions they are required for:

  1. The version 4 family of the net framework. For the net 3.x the library may also compiled, at the moment I do not remember if I am using something that was introduced with version 4. It is a matter of trying, if it does it will also require this condition.
  2. The netstandard family. I don't know what the version 2.0 does that the 2.1 doesn't, never used.
  3. netCore and NET 5 have no special requirements.
DavidWishengrad commented 2 years ago

Sorry but I will not provide compiled versions of this library anymore only as source code and I am not related in anyway with the available nuget downloads

I do not know what you are apologizing for. Your code compiles just fine in VS 2019, as you state to use, and I cannot see why anyone can't do that for themselves. Setting the target and clicking rebuild solution works immediately. I cannot think of anything else you could have done to make this easier for anyone. It is already as easy as reasonably humanly possible. Your included samples are gems.

As for nuget. Thank you for the head's-up.

edit... I have been reading the posts, bug reports and more here as the time permits. I see now you have already mentioned the nuget issue many times.

ikorin24 commented 2 years ago

@haplokuon Thanks for the reply.

I am not related in anyway with the available nuget downloads.

Oh sorry, I did not know that and assumed you had released it.

I will fork the repository and customize it for myself. Thanks for the great source code !!