search

hapostgres / pg_auto_failover

Postgres extension and service for automated failover and high-availability
Other
1.12k stars 115 forks source link

fix: Allow setting maximum-backup-rate on create postgres step #812

Closed amontalban closed 3 years ago

amontalban commented 3 years ago

This PR allows configuring the maximum-backup-rate setting when running pg_autoctl create postgres.

Fixes #780

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

DimCitus commented 3 years ago

It's now failing the make indent checks. If you can, check out our https://github.com/citusdata/pg_auto_failover/blob/master/CONTRIBUTING.md guidelines and then do make indent and push the new version of your PR, otherwise I'm going to look into doing that myself (but I'm not sure if I'm allowed to push to your branch).

amontalban commented 3 years ago

It's now failing the make indent checks. If you can, check out our https://github.com/citusdata/pg_auto_failover/blob/master/CONTRIBUTING.md guidelines and then do make indent and push the new version of your PR, otherwise I'm going to look into doing that myself (but I'm not sure if I'm allowed to push to your branch).

Sorry @DimCitus, I tried that before in my macOS but the Makefile was failing. I got it working and I think it should pass now.

DimCitus commented 3 years ago

Thanks for your work @amontalban ; both the bug report and now the bug fix, and welcome to the pg_auto_failover contributors team!