search

hapostgres / pg_auto_failover

Postgres extension and service for automated failover and high-availability
Other
1.07k stars 113 forks source link

Fix monitor extension for new Postgres 15 shared memory hooks. #922

Closed DimCitus closed 1 year ago

DimCitus commented 1 year ago

We should probably edit the GitHub Actions settings and replace Postgres 10 with Postgres 15 as part of this PR. To test manually, do the following:

$ make TEST=test_installcheck PGVERSION=15 run-test
DimCitus commented 1 year ago

I think the C code changes look good (other than the compile issue), I'll ask @hanefi to have a quick look to the Makefile and docker changes.

Thanks for the review, I fixed the PG_VERSION_15 macro... because I didn't get a warning on compile I though it might have been provided by Postgres and I would have missed it somehow. I'm back to using 150000 which is good enough here I believe.

Also about the Docker changes, I think it's good to go. Our Dockerfile organisation made it very easy to include that, I'm not worried about these parts, and they're easy to test locally too.