hapostgres / pg_auto_failover

Postgres extension and service for automated failover and high-availability
Other
1.07k stars 113 forks source link

Documentation doesn't match the code for `health_check_period` #925

Closed jamielinux closed 1 year ago

jamielinux commented 1 year ago

Code here sets 5 seconds for health_check_period:

    DefineCustomIntVariable("pgautofailover.health_check_period",
                            "Duration between each check (in milliseconds).",
                            NULL, &HealthCheckPeriod, 5 * 1000, 1, INT_MAX, PGC_SIGHUP,
                            GUC_UNIT_MS, NULL, NULL, NULL);

Documentation here says 20 seconds for health_check_period:

   SELECT name, setting
     FROM pg_settings
    WHERE name ~ 'pgautofailover\.health';
                   name                   | setting
 -----------------------------------------+---------
  pgautofailover.health_check_max_retries | 2
  pgautofailover.health_check_period      | 20000
  pgautofailover.health_check_retry_delay | 2000
  pgautofailover.health_check_timeout     | 5000
 (4 rows)
jamielinux commented 1 year ago

Fixed by https://github.com/citusdata/pg_auto_failover/pull/926