search

hapostgres / pg_auto_failover

Postgres extension and service for automated failover and high-availability
Other
1.07k stars 112 forks source link

Fixed what I believe to be a mistake in setup description #984

Closed fuyfuy closed 1 year ago

fuyfuy commented 1 year ago

Description of setup with multiple standby with one async node doesn't make sense to me. I suggest to fix it, since it's an introduction article which everybody reads first, so ideally it should be correct.

fuyfuy commented 1 year ago

@DimCitus Dimitri, what's my next steps to merge the PR? It says "Merging is blocked. The base branch restricts merging to authorized users."

DimCitus commented 1 year ago

@DimCitus Dimitri, what's my next steps to merge the PR? It says "Merging is blocked. The base branch restricts merging to authorized users."

Hi @fuyfuy ; thanks for your contribution to pg_auto_failover! The process that we follow here is that I'm going to merge your PR, and for that I need full success on the CI testing. At the moment this is not possible because of a compilation issue with Citus when using Postgres 14, Citus needs to publish a new release and I need to update our CI matrix setup then. After we've done that, tests here should all pass and I will be in a position to merge your PR.

fuyfuy commented 1 year ago

Thanks a lot @DimCitus, that's what I thought. Thanks for your work on pg_auto_failover (and the books as well!)