happenslol / WarpDeplete

Mythic+ Timer Addon for World of Warcraft
MIT License
16 stars 19 forks source link

[Feature Request] Add estimated progress AFTER current pull #48

Closed Ulu2005 closed 1 year ago

Ulu2005 commented 1 year ago

Hi thanks for your awesome work. I often found it's hard to do the math for calculating the current pull + current progress when tanking. It makes a difference for tank to decide whether I want to pull another pack to fill the progress.

It would be nice to have the estimated percentile after current pull like this WA https://wago.io/8z3cFNJGT

happenslol commented 1 year ago

Hey, thanks for the request! Adding the percent after pull (and absolute count after pull) should be pretty easy, and I can definitely include this in the next release. Until then, you can have a look at the custom options that are already available:

:remainingpercentafterpull: should give the percent that's still missing after the current pull is completed.

Ulu2005 commented 1 year ago

Thanks for the prompt reply! Yeah this custom options definitely helps, just updated my setting to use it now as a workaround, although it's not exact matching my use case.

So it's about tank want to reach certain percentile before going to next area, e.g. 94% in NOK before last boss area, 93% in COS before 2nd boss(more examples in https://wago.io/wuwOfm5ec). Again, thanks!

happenslol commented 1 year ago

Yeah, that makes a lot of sense. I'll probably start playing a lot again in the coming weeks, so look forward to that option in the custom format strings soon :-)

andre1808 commented 1 year ago

I'm not to much into coding, but I think I've added the custom option by myself (probably not really clean though :) Util.lua, replace line 16 to 55 with https://pastebin.com/s2RmA0NK Options.lua, replace line 373 with https://pastebin.com/YinrTeA3

Again: I'm not a coder and it may not work 100% :) so if you rely on the addon, wait for the update by @happenslol

happenslol commented 1 year ago

This has been implemented in #53 and is included in the newest version. Please open another issue if there's any functionality missing.