search

happenslol / WarpDeplete

Mythic+ Timer Addon for World of Warcraft
MIT License
16 stars 19 forks source link

Add default value for :percentafterpull: placeholder #54

Closed Cy4n1d3 closed 1 year ago

Cy4n1d3 commented 1 year ago

If :percentafterpull: ist not calculated due to pull not having count, we replace it with the current force percentage as a default value. This is a small fixup for #53 which I noticed while running some keys :)

I also noticed some oddities after key completion (percentage being displayed as 0%), but that is most probably due to forces being completed and pulls not being updated after (?).

happenslol commented 1 year ago

Alright, I'mma just trust you on this :-P I'll look into the 0% thing later. We generally don't do much to keep correct state after key completion, that's another todo I guess...

Cy4n1d3 commented 1 year ago

I didn't notice this until I actually fought a boss (which gives 0 count). :D Thanks!