search

happenslol / WarpDeplete

Mythic+ Timer Addon for World of Warcraft
MIT License
16 stars 21 forks source link

Percent After Pull String not working #57

Open Aeon234 opened 1 year ago

Aeon234 commented 1 year ago

With the new update it was documented that :percentafterpull: should display the percent after the pull is finished, but when using the custom text format and placing :percentafterpull: string, instead of the actual percentage all you get is just the string being displayed as text. Doesn't matter if it's in demo mode or in an actual dungeon.

For reference on the picture below the custom text is: (+:count: / :percent:) (:percentafterpull:)

image

happenslol commented 1 year ago

Thanks for the report, I'll have a look at this.

happenslol commented 1 year ago

I just checked ingame, and it seems to work fine for me. Just a hunch... Could it be that you inserted the :percentafterpull: tag in the "Current pull text format" box, and not in the "Forces text format" box? We don't replace that tag in there, but maybe we should. There's not really any reason to not make all tags available in both fields, the only difference is that the second one is only display while you have an active pull.

Aeon234 commented 1 year ago

Yup, exactly. I placed it in the Current pull text format. I've just trained my eyes to go to that specific string when it comes to figuring out whether the current pull is sufficient.

image

happenslol commented 1 year ago

Ah right, that's the problem then. The string will only be replaced in the forces text, not the current pull text. I can add the other replacements to the current pull text as well and include that in the next release, but until then you'll have to use the forces text for that field.