search

happenslol / WarpDeplete

Mythic+ Timer Addon for World of Warcraft
MIT License
16 stars 21 forks source link

Re-implement objective clear timings #58

Closed happenslol closed 6 months ago

happenslol commented 1 year ago

I'm pretty confident that this should work now, but I haven't had the time to do too much playtesting, so I'd appreciate if you could also run a few dungeons on this branch and tell me if there are any issues. I'd like to avoid pushing out a new version too fast, since we've already done so once :-P

The only feature I haven't ported over from the previous version is the ability to also display timings if only a key level lower or higher was recorded. What exactly did you have in mind for that @Floppy012?

Floppy012 commented 1 year ago

Nice. I'm running some keys tonight and will use the code from this PR.

The only feature I haven't ported over from the previous version is the ability to also display timings if only a key level lower or higher was recorded. What exactly did you have in mind for that @Floppy012?

What I did was if no recordings exist for the current keylevel, simply use the next lower level by lowering the level until we either find a recording or reach level 2. If we're at level 2 and no recordings have been found simply don't show the diffs.

That being said something that came to my head recently was, that we should show somewhere what keystone level we're comparing the current run to.

happenslol commented 1 year ago

Just noticed that there's an issue with my implementation - Using the "record only completed runs" option will fail right now, since in that case I only write timings after the entire run is finished. Instead, the code that sets the timing should be split into setting the current and the saved timing, and the current timing should always be set, while the saved timing happens at the end like it does currently.

So, if you're testing it tonight, you should keep "record only completed runs" disabled to get correct numbers during the run. I'll fix this as soon as possible.

Aeon234 commented 1 year ago

Any chance this is coming as an update soon? Would love to see the record timers without having to switch to a different timer. Thanks!

happenslol commented 1 year ago

I'm currently very busy and not playing WoW at all as a result. That means that I can't currently test this well since I'm not actively running dungeons, and I don't want to release a half-baked version. I will definitely be playing again when the next patch hits, but until then I can't make any promises.

I would be open to reviewing a PR though, so if you want to finish this implementation based on what I've done here you're welcome to do so!