happenslol / WarpDeplete

Mythic+ Timer Addon for World of Warcraft
MIT License
16 stars 19 forks source link

LUA Error when starting key in 11.0 Pre-Patch. WarpDeplete never shows. #68

Closed Erieeroot closed 1 month ago

Erieeroot commented 1 month ago

Hey there :)

Running few addons at this point as things are slowly being updated. As this error suggests, I have ElvUI. Didn't see any other reports on here so thought I would post it up. Ran 5-6 keys yesterday and this is what I get.

Thanks!

8x WarpDeplete/Events.lua:194: attempt to call field 'GetCriteriaInfo' (a nil value) [string "@WarpDeplete/Events.lua"]:194: in function GetEnemyForcesCount' [string "@WarpDeplete/Events.lua"]:161: in functionGetObjectivesInfo' [string "@WarpDeplete/Events.lua"]:37: in function StartChallengeMode' [string "@WarpDeplete/Events.lua"]:432: in function?' [string "@ElvUI_Libraries/Core/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:109: in function <...ies/Core/CallbackHandler-1.0/CallbackHandler-1.0.lua:109>

[string "@ElvUI_Libraries/Core/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...ies/Core/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@ElvUI_Libraries/Core/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire' [string "@ElvUI_Libraries/Core/Ace3/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function <...UI_Libraries/Core/Ace3/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals: self =

{ modules =
{ } Glow =
{ } db =
{ } defaultObjectivesState =
{ } bar1 =
{ } name = "WarpDeplete" LSM =
{ } L =
{ } bar2 =
{ } defaultForcesState =
{ } bars =
{ } bar3 =
{ } baseName = "WarpDeplete" defaultModuleState = true forcesState =
{ } Util =
{ } frames =
{ } enabledState = true forces =
{ } configDialog =
{ } optionsGeneralFrame = Frame { } isUnlocked = false keyDetailsState =
{ } objectivesState =
{ } challengeState =
{ } defaultModuleLibraries =
{ } defaultKeyDetailsState =
{ } timerState =
{ } orderedModules =
{ } isShown = false defaultChallengeState =
{ } defaultTimerState =
{ } } stepCount = 5 (temporary) = nil (temporary) = 5 (*temporary) = "attempt to call field 'GetCriteriaInfo' (a nil value)"

happenslol commented 1 month ago

Whelp, seems like they changed the API. Thanks for the report. I'm not playing the beta currently, so it might take a bit until I get around to fixing this. I'm open to reviewing pull requests, though!

happenslol commented 1 month ago

Just looked it up and it seems like they just moved it to a different namespace, so it could be an easy fix. Would you be willing to test a beta version for me if I try that tomorrow?

Erieeroot commented 1 month ago

Just looked it up and it seems like they just moved it to a different namespace, so it could be an easy fix. Would you be willing to test a beta version for me if I try that tomorrow?

Sure thing! Happy to help however I can.

happenslol commented 1 month ago

Fixed in #70.

There are still some issues with the count, but the problems seem to be on the Blizzard API side. Since this specific issue is fixed, I'll go ahead and close this for now. Feel free to open another issue for any further problems, but keep in mind that we might currently not be able to fix everything.