happenslol / WarpDeplete

Mythic+ Timer Addon for World of Warcraft
MIT License
16 stars 19 forks source link

Base registered chat commands not functioning #69

Closed Erieeroot closed 1 month ago

Erieeroot commented 1 month ago

This is a separate issue so I guess I will start another lol.

Typing any of the base registered chat commands yields a LUA error (wpd, warp, warpdeplete, WarpDeplete).

Providing an argument works as expected though... i.e. /warp demo, /warp debug.

ALSO, navigating to the options in Options > AddOns > WarpDeplete displays the options so it isn't a huge issue, just a minor annoyance I suppose :).

The error points to the OpenToCategory call, which I played around with Settings.OpenToCategory, and some other things I found around the web but no dice. C, Powershell, and VB are in my repertoire, but LUA I haven't played with enough to be much more help outside of a few plugins I made for other addons lol.

I saw where in 11.0.2 they are making changes to OpenToCategory allowing you to call directly to subcategories...but not much more mention of it, and nothing really for 11.0.0. InterfaceOptionsFrameOpenToCategory had that bug where you had to call it twice, but from what I have seen digging in other addons, Settings.OpenToCategory seems to be widely used...obviously didn't fix it but maybe that info is useful? ¯_(ツ)

Here is the error:

2x WarpDeplete/Options.lua:790: attempt to call global 'InterfaceOptionsFrame_OpenToCategory' (a nil value) [string "@WarpDeplete/Options.lua"]:790: in function ?' [string "@ElvUI_Libraries/Core/Ace3/AceConsole-3.0-7/AceConsole-3.0.lua"]:90: in function?' [string "@Blizzard_ChatFrameBase/Mainline/ChatFrame.lua"]:5440: in function <Blizzard_ChatFrameBase/Mainline/ChatFrame.lua:5386> [string "=[C]"]: in function ChatEdit_ParseText' [string "@Blizzard_ChatFrameBase/Mainline/ChatFrame.lua"]:5092: in function <Blizzard_ChatFrameBase/Mainline/ChatFrame.lua:5091> [string "=[C]"]: in functionChatEdit_SendText' [string "@Blizzard_ChatFrameBase/Mainline/ChatFrame.lua"]:5128: in function <Blizzard_ChatFrameBase/Mainline/ChatFrame.lua:5124> [string "=[C]"]: in function `ChatEdit_OnEnterPressed'

Locals: self =

{ modules =
{ } Glow =
{ } db =
{ } defaultObjectivesState =
{ } bar1 =
{ } name = "WarpDeplete" LSM =
{ } L =
{ } bar2 =
{ } defaultForcesState =
{ } bars =
{ } bar3 =
{ } baseName = "WarpDeplete" defaultModuleState = true forcesState =
{ } Util =
{ } frames =
{ } enabledState = true forces =
{ } configDialog =
{ } optionsGeneralFrame = Frame { } isUnlocked = false keyDetailsState =
{ } objectivesState =
{ } challengeState =
{ } defaultModuleLibraries =
{ } defaultKeyDetailsState =
{ } timerState =
{ } orderedModules =
{ } isShown = true defaultChallengeState =
{ } defaultTimerState =
{ } } input = "" cmd = "" (temporary) = nil (temporary) = "WarpDeplete" (*temporary) = "attempt to call global 'InterfaceOptionsFrame_OpenToCategory' (a nil value)"

XCreative commented 1 month ago

To fix this, replace the lines 788, 789, 790, 791 in the Options.lua

 -- We have to call this twice in a row due to a stupid bug...
 -- See https://www.wowinterface.com/forums/showthread.php?t=54599
 InterfaceOptionsFrame_OpenToCategory("WarpDeplete")
 InterfaceOptionsFrame_OpenToCategory("WarpDeplete")

With

-- Fix InterfaceOptionsFrame_OpenToCategory deprecation issue
Settings.OpenToCategory("WarpDeplete")
Erieeroot commented 1 month ago

Crazy...I swore I did that last night and got the same error.... Maybe I left the underscore instead of the dot....smh well now I feel dumb lol. That did the trick.

The answer was right in my face :)

happenslol commented 1 month ago

Fixed in #72. Thank you!