search

happo / happo-cypress

A Happo integration with Cypress.io
35 stars 4 forks source link

Review types for happo-cypress #63

Closed alexanderpolyankin closed 3 years ago

alexanderpolyankin commented 3 years ago

Hey! I've encountered similar issues as in https://github.com/happo/happo-cypress/issues/17. With typescript, you have to add type definitions manually to call happo-cypress methods. I'd like to publish these types to DefinitelyTyped. Here are the types: https://github.com/alexanderpolyankin/DefinitelyTyped/tree/master/types/happo-cypress. Can you please review them? Are you ok with publishing these types?

The reason why I want to publish these types as @types is because typeRoots are set to @types by default, so it's the only option that won't require consumers to change their tsconfig settings.

trotzig commented 3 years ago

Hi @alexanderpolyankin! Sorry - I totally missed this. I've reviewed the types and they look good 👍. You can go ahead and publish.

alexanderpolyankin commented 3 years ago

Thanks a lot, merged!