search

happo / happo-cypress

A Happo integration with Cypress.io
35 stars 4 forks source link

Types for happo-cyrpress installing an old version of Cypress #93

Closed Belco90 closed 2 years ago

Belco90 commented 2 years ago

Hi there!

I've been using Happo for a while for this project. Really happy with it, great Visual Testing tool!

I just realized I was getting two different Cypress versions installed in my system: v9 (the one I use) and v6. It turns out the package types/happo-cypress is setting cypress@6 as a dependency, so I guess this isn't correctly indicated?

CleanShot 2022-04-09 at 15 06 21

I know the types are managed directly within DefinitelyTyped, but I wanted to flag the issue here. I'll try to create a PR in DefinitelyTyped to fix this, I guess I can entirely remove cypress as dependency of those types, right?

Belco90 commented 2 years ago

It seems it's not that straightforward! https://github.com/DefinitelyTyped/DefinitelyTyped/pull/57460

Belco90 commented 2 years ago

Updated here 🤞 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/59790

Belco90 commented 2 years ago

Solved! @types/happo-cypress v3 was published: https://www.npmjs.com/package/@types/happo-cypress

trotzig commented 2 years ago

@Belco90 Thanks a bunch for pushing this through! This whole issue managed to slip through the cracks -- I salute you for pushing it through by yourself! 🎉