Add option for dynamic channels

happyDemon / vue-echo

Vue integration for the Laravel Echo library.

228 stars 24 forks source link

Closed kamerat closed 2 years ago

kamerat commented 5 years ago

Fixes #13

Added a way to add dynamic channels.
Fixed better checks for correct channel input
Moved beforeDestroy to mounted as a programmatic listener to cut down on validation code
Refactored some pre ES6 function declarations to arrow functions (there was a mix of both): function () {...} -> () => {...}

happyDemon commented 5 years ago

thanks for the PR, I'll check things out when I get home and get a build ready

kamerat commented 5 years ago

Hey, @happyDemon! Sorry if I'm bothering you with this. Do you have some time to spare to review the PR? :) Have a nice easter, my dude. 🐣

wardy484 commented 5 years ago

😅 I was about to create a PR for this extact thing. 👍 Would be great if this was merged.

kamerat commented 2 years ago

Closing due to inactivity ⌚